Merged
Conversation
iwillspeak
previously approved these changes
Dec 1, 2025
Member
|
Can we add a README into the images folder with a copyright declaration explaining the licensing for them. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Better Logging, Enhanced Error Handling, and Updated Expected Outputs
* feat: correlationid can be specified on ImageData * feat: set brotli compression quality * style: lint * fix: fixup example code * feat: configurable resizing algorithm --------- Co-authored-by: anna-singleton-resolver <anna.singleton@resolver.com>
…tream - Call results.aclose() before breaking from response loop to properly terminate the async generator and underlying gRPC stream - Update snapshot for lakeside/pexels-pixabay-210288.jpg (weight 0.9259 -> 0.9215) - Apply same fix to examples/utils for consistency
Add aclose() in exception handlers to ensure the gRPC stream is terminated even when an error occurs during classification.
iwillspeak
previously approved these changes
Feb 13, 2026
iwillspeak
requested review from
anna-singleton-resolver,
Copilot and
snus-kin
iwillspeak
previously approved these changes
Feb 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds end-to-end functional tests for the benign test version of the model, improves streaming classification resource cleanup, and updates test configurations.
Changes:
- Added E2E functional tests using specific test case images from athena-protobufs
- Fixed resource leaks in streaming classification by explicitly closing async generators
- Updated test configurations including reduced default test image count and added VS Code test settings
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/functional/e2e/testcases/parser.py | New test case parser for loading expected outputs from athena-protobufs |
| tests/functional/e2e/test_classify_single.py | New E2E test validating classification output against expected results |
| tests/functional/test_color_channels.py | New functional test for RGB color channel classification |
| tests/utils/streaming_classify_utils.py | Added async generator cleanup calls to prevent resource leaks |
| examples/utils/streaming_classify_utils.py | Added async generator cleanup calls to prevent resource leaks |
| tests/functional/test_classify_streaming.py | Reduced default test image count and skipped flaky test |
| tests/functional/conftest.py | Changed credential_helper fixture scope to session |
| examples/classify_single_example.py | Made affiliate configurable via environment variable |
| athena-protobufs | Updated submodule to include test cases |
| .vscode/settings.json | Added VS Code pytest configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
iwillspeak
force-pushed
the
feature/e2e-func-tests
branch
from
6970bf2 to
0fa3ed9
Compare
iwillspeak
force-pushed
the
feature/e2e-func-tests
branch
from
0fa3ed9 to
4bedcac
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
iwillspeak
approved these changes
Feb 13, 2026
JohnnyWombwell
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds end to end functional tests with specific test case images using those in crispthinking/athena-protobufs#36.